Conversation
Co-authored-by: cvraut <10603882+cvraut@users.noreply.github.com>
Co-authored-by: cvraut <10603882+cvraut@users.noreply.github.com>
…dency Copilot/remove pkg resources dependency merging into dev to allow for testing. Note, in the future PR's should be made to dev first. Branch rules disallow automated testing on branches other than dev and main to protect the webhook test urls.
…314 as other python versions to check against
|
I think this last set of commits should fix everything with the auto-test env after I land in boston I need to build the wheel, deploy to pypi, merge this PR, and close the issue. |
cvraut
left a comment
cvraut
left a comment
There was a problem hiding this comment.
pytest.yml, pyproject.toml, and tox.ini changes are to support the recent actions upgrade while stilling maintaining tests on python 3.6
_config.py and _utilities.py both use metadata from importlib instead of pkg_resources to retreive version info. Note, importlib behavior changes in python 3.8, so behavior is wrapped in try-except with an alias to support older python versions.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes package metadata retrieval by replacing the deprecated pkg_resources with importlib.metadata (and its backport for older Python versions). It also expands CI/CD testing coverage across multiple Python versions.
- Replaced
pkg_resources.get_distribution()withimportlib.metadata.version()for retrieving package version - Added conditional import logic to support both Python >= 3.8 (built-in) and Python < 3.8 (backport package)
- Enhanced CI/CD testing to include Python 3.6 (minimum supported), 3.9 (primary dev), and 3.14 (latest)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| whecho/_utilities.py | Migrated from pkg_resources to importlib.metadata with backward compatibility fallback |
| whecho/_config.py | Migrated from pkg_resources to importlib.metadata with backward compatibility fallback |
| pyproject.toml | Bumped version to 0.0.6 and added importlib-metadata as conditional dependency for Python < 3.8 |
| tox.ini | Updated test configuration to support multiple Python versions with isolated builds |
| .github/workflows/pytest.yml | Expanded test matrix to include Python 3.6, 3.9, and 3.14 across different OS platforms |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s can actually see it now
…exposed to the test environment
|
This PR is super messy, gonna close this one and open a new one. |
try new test suite from dev branch